Skip to content

[Analytics Hub] Store views for SiteVisitStats (Storage) #8387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 13, 2022
Merged

[Analytics Hub] Store views for SiteVisitStats (Storage) #8387

merged 4 commits into from
Dec 13, 2022

Conversation

@rachelmcr
Copy link
Contributor

@rachelmcr rachelmcr commented Dec 12, 2022 •
edited
Loading

Part of: #8363
⚠️ Depends on #8386 ⚠️

Description

This PR is a followup to changes to Networking in #8386. Now that we are requesting views when we get SiteVisitStats, this PR updates the Storage layer so we store them (as part of SiteVisitStatsItem).

We don't strictly need this storage support for the Analytics Hub (we aren't planning to store data from those requests or fetch data from storage) but I'm adding it for completeness since we already store these stats items and use them elsewhere in the app.

Changes

  • Adds a new Core Data model 79.
  • Adds a views attribute to the SiteVisitStatsItem entity in storage.
  • Updates the corresponding ReadOnlyConvertible and CoreDataProperties, and unit tests.

Note: Most of the lines of changes in this PR are the new Core Data model, but the only change in the new model is the new attribute.

Testing

This views attribute is not yet used in the app, so confirm unit tests look as expected and still pass.

Submitter Checklist

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@rachelmcr rachelmcr added the feature: stats Related to stats, including Top Performers. label Dec 12, 2022
@rachelmcr rachelmcr added this to the 11.7 milestone Dec 12, 2022
@rachelmcr rachelmcr marked this pull request as ready for review December 12, 2022 16:42
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Dec 12, 2022

You can test the changes from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr8387-3935f3c on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ealeksandrov ealeksandrov self-assigned this Dec 13, 2022
ealeksandrov
ealeksandrov approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@ealeksandrov ealeksandrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ealeksandrov ealeksandrov removed their assignment Dec 13, 2022
@rachelmcr rachelmcr force-pushed the issue/8363-jetpack-stats-views branch from ca7dbc2 to cecfaa8 Compare December 13, 2022 13:04
Base automatically changed from issue/8363-jetpack-stats-views to trunk December 13, 2022 13:45
@rachelmcr rachelmcr merged commit 262b573 into trunk Dec 13, 2022
@rachelmcr rachelmcr deleted the issue/8363-jetpack-stats-views-storage branch December 13, 2022 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Ecarrion Ecarrion Awaiting requested review from Ecarrion

@ThomazFB ThomazFB Awaiting requested review from ThomazFB

1 more reviewer

@ealeksandrov ealeksandrov ealeksandrov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

feature: stats Related to stats, including Top Performers.

Projects

None yet

Milestone

11.7

Development

Successfully merging this pull request may close these issues.

4 participants

@rachelmcr @wpmobilebot @ealeksandrov